All files messagesController.js

99.67% Statements 309/310
89.95% Branches 206/229
100% Functions 39/39
100% Lines 296/296

Press n or j to go to the next uncovered block, b, p or k for the previous block.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177                              1x 1x 1x 1x     1x     1x                 29x 29x 22x               22x               22x             2x             25x 25x 20x       9x       12x       3x             3x       14x 14x 6x             14x             9x             9x       5x 1x 1x   4x 4x 2x 2x   2x       5x 4x 4x 1x 1x   3x       3x 1x 1x   2x                   13x 13x 10x     3x 3x               3x 3x       3x       2x       2x       1x                     2x                                                 2x 2x 2x       2x 2x 1x                                         2x 2x 2x   2x 2x                                                                           1x 1x                                         1x                             7x 7x   7x 1x         6x 1x         5x   5x       4x 1x           3x         3x 3x 1x               2x 2x 1x               1x     1x           1x               1x   1x                             4x 4x   4x 1x       3x             3x   2x 2x   2x       2x   1x                           1x   1x                           1x     2x     1x 1x 2x 2x 1x               1x 1x 1x                 2x                                               1x           1x                             8x 8x   8x 1x       7x             7x     6x 6x 6x 1x             5x 5x 1x           4x 4x 1x           3x 3x     2x 2x 2x   2x 2x             1x           1x                           1x 1x     1x 1x 1x 1x   1x   1x         1x                           4x 4x   4x 1x       3x             3x   2x 2x                 1x     1x 1x 1x 1x 1x       1x   1x                             2x   2x 2x                     1x   1x                               6x 6x 6x 1x     5x   5x                   4x 1x     3x     3x 1x     2x 1x     1x           1x 1x 1x           1x   1x                           7x 7x 7x 1x     6x 6x 1x               5x 5x       5x   5x                   5x 1x       4x 1x       3x           2x 1x     1x   1x                           6x 6x 6x 1x     5x 5x 1x             4x   4x                   3x 1x     2x     2x           2x 1x       1x   1x       1x       2x         2x 2x 2x 1x                   2x   1x                           5x 5x 5x 1x     4x 4x   3x 3x 1x     2x   2x   2x                           1x 1x                     1x                             5x 5x 5x 1x     4x 4x 1x     3x 3x 1x     2x   2x         1x 1x   1x 1x   1x                   1x   1x                           4x 4x   4x 1x     3x   3x 2x 1x       1x         1x   1x                       3x 3x   3x 1x     2x 2x       1x   1x                       2x 2x 2x               1x       1x               1x                           1x  
"use strict";
 
/**
 * MessagesController – Backend REST pour la messagerie FailDaily
 *
 * Sécurité :
 *  - Toutes les méthodes supposent que req.user est déjà vérifié par authenticateToken.
 *  - Chaque accès à une conversation vérifie que l'utilisateur en est membre.
 *  - Les IDs de conversations (BIGINT) sont parsés et validés.
 *  - Le contenu des messages est tronqué à 2000 caractères (sanity) en plus de la validation express-validator.
 *  - Pas de données d'un autre utilisateur exposées sans vérification.
 *  - Requêtes paramétrées uniquement (pas de concaténation SQL).
 *  - Emojis validés côté serveur (ensemble autorisé).
 */
 
const { executeQuery } = require("../config/database");
const { logSystem } = require("../utils/logger");
const { sendPushToUser } = require("../utils/push");
const SERVER_ERROR_RESPONSE = { success: false, error: "Erreur serveur" };
 
// Emojis autorisés pour les réactions (liste fermée → évite injection d'emoji malformés)
const ALLOWED_EMOJIS = new Set(["👍","👎","❤️","😂","😮","😢","😡","🔥","👏","🎉","💯","🤔","😍","🥳","💪"]);
 
// Raisons de signalement valides
const VALID_REPORT_REASONS = new Set(["spam","harassment","inappropriate","hate_speech","other"]);
 
// ─── Helpers ──────────────────────────────────────────────────────────────────
 
/**
 * Parse et valide un ID de conversation (BIGINT UNSIGNED).
 * Retourne null si invalide.
 */
function parseConvId(raw) {
  const n = Number.parseInt(raw, 10);
  if (!Number.isFinite(n) || n <= 0 || String(n) !== String(raw)) return null;
  return n;
}
 
/**
 * Retourne la conversation si req.user en est membre, sinon null.
 * Requête single-hit avec vérification d'appartenance intégrée.
 */
async function getConversationIfMember(conversationId, userId) {
  const rows = await executeQuery(
    `SELECT id, user1_id, user2_id, last_message_at, created_at
       FROM conversations
      WHERE id = ?
        AND (user1_id = ? OR user2_id = ?)
      LIMIT 1`,
    [conversationId, userId, userId],
  );
  return rows.length ? rows[0] : null;
}
 
/**
 * Normalise la paire (a, b) pour respecter la contrainte user1_id < user2_id.
 */
function orderUsers(a, b) {
  return a < b ? [a, b] : [b, a];
}
 
/**
 * Parse et valide un ID de message (BIGINT UNSIGNED).
 */
function parseMessageId(raw) {
  const n = Number.parseInt(raw, 10);
  if (!Number.isFinite(n) || n <= 0) return null;
  return n;
}
 
function sendInvalidId(res, fieldName) {
  return res.status(400).json({ success: false, error: `${fieldName} invalide` });
}
 
function sendSuccess(res, payload = {}) {
  return res.json({ success: true, ...payload });
}
 
function sendForbiddenConversation(res) {
  return res.status(403).json({
    success: false,
    error: "Accès refusé à cette conversation",
  });
}
 
function sendMessageNotFound(res) {
  return res.status(404).json({ success: false, error: "Message introuvable" });
}
 
async function logAndSendServerError(res, { label, error, action, userId }) {
  console.error(label, error);
  if (action && userId) {
    await logSystem({
      level: "error",
      action,
      message: error.message,
      userId,
    });
  }
  return res.status(500).json(SERVER_ERROR_RESPONSE);
}
 
/**
 * Vérifie si userA a bloqué userB ou vice-versa.
 */
async function isBlockedBetween(userA, userB) {
  const rows = await executeQuery(
    `SELECT 1 FROM user_blocks
      WHERE (blocker_id = ? AND blocked_id = ?)
         OR (blocker_id = ? AND blocked_id = ?)
      LIMIT 1`,
    [userA, userB, userB, userA],
  );
  return rows.length > 0;
}
 
async function validateFailRef(failRefId, res) {
  if (typeof failRefId !== "string" || failRefId.length > 36) {
    res.status(400).json({ success: false, error: "failRefId invalide" });
    return false;
  }
  const failRows = await executeQuery(`SELECT id FROM fails WHERE id = ? LIMIT 1`, [failRefId]);
  if (!failRows.length) {
    res.status(404).json({ success: false, error: "Fail de référence introuvable" });
    return false;
  }
  return true;
}
 
async function parseAndValidateReplyTo(rawReplyTo, convId, res) {
  if (rawReplyTo == null) return { valid: true, replyToId: null };
  const replyToId = parseMessageId(rawReplyTo);
  if (!replyToId) {
    res.status(400).json({ success: false, error: "replyToId invalide" });
    return { valid: false };
  }
  const replyRows = await executeQuery(
    `SELECT id FROM messages WHERE id = ? AND conversation_id = ? LIMIT 1`,
    [replyToId, convId],
  );
  if (!replyRows.length) {
    res.status(404).json({ success: false, error: "Message de référence introuvable" });
    return { valid: false };
  }
  return { valid: true, replyToId };
}
 
async function ensureConversationAccess({
  conversationId,
  userId,
  res,
  warnAction,
  warnMessage,
}) {
  const conv = await getConversationIfMember(conversationId, userId);
  if (conv) {
    return conv;
  }
 
  Eif (warnAction && warnMessage) {
    await logSystem({
      level: "warn",
      action: warnAction,
      message: warnMessage,
      userId,
    });
  }
 
  sendForbiddenConversation(res);
  return null;
}
 
async function findUserById(userId) {
  const rows = await executeQuery(
    `SELECT id FROM users WHERE id = ? LIMIT 1`,
    [userId],
  );
  return rows[0] || null;
}
 
function mapReactionCounts(counts) {
  return counts.map((r) => ({ emoji: r.emoji, count: Number(r.count) }));
}
 
function mapBlockedUserRow(row) {
  return {
    userId: row.blocked_id,
    displayName: row.display_name || "Utilisateur",
    avatarUrl: row.avatar_url || null,
    blockedAt: row.created_at,
  };
}
 
// ─── Helpers sendMessage ──────────────────────────────────────────────────────
 
function buildMsgPayload(msg, convId) {
  return {
    id: msg.id,
    conversationId: convId,
    senderId: msg.sender_id,
    senderDisplayName: msg.sender_display_name,
    senderAvatarUrl: msg.sender_avatar_url,
    content: msg.content,
    failRef: msg.fail_ref_id ? { id: msg.fail_ref_id } : null,
    replyTo: msg.reply_to_id
      ? {
          id: msg.reply_to_id,
          content: msg.reply_content,
          senderId: msg.reply_sender_id,
          senderDisplayName: msg.reply_sender_name,
        }
      : null,
    reactions: [],
    isDeleted: false,
    readAt: msg.read_at,
    createdAt: msg.created_at,
    isOwn: true,
  };
}
 
function scheduleMsgPush(otherUser, convId, content, senderName) {
  setImmediate(async () => {
    try {
      const muteRows = await executeQuery(
        "SELECT is_muted FROM conversation_settings WHERE user_id = ? AND conversation_id = ? LIMIT 1",
        [otherUser, convId],
      );
      const isMuted = muteRows.length > 0 && !!muteRows[0].is_muted;
      if (!isMuted) {
        await sendPushToUser(otherUser, {
          title: `${senderName} vous a écrit`,
          body: content.length > 80 ? content.slice(0, 80) + "…" : content,
          data: { type: "new_message", conversationId: String(convId) },
        });
      }
    } catch {
      // Push non critique
    }
  });
}
 
// ─── Controllers ──────────────────────────────────────────────────────────────
 
class MessagesController {
  /**
   * GET /api/messages/conversations
   * Liste les conversations de l'utilisateur triées par dernier message.
   * Inclut le nombre de messages non lus et le dernier message.
   */
  static async getConversations(req, res) {
    const userId = req.user.id;
    const limit = Math.min(Number.parseInt(req.query.limit, 10) || 20, 50);
    const offset = Math.max(Number.parseInt(req.query.offset, 10) || 0, 0);
 
    try {
      const rows = await executeQuery(
        `SELECT
            c.id,
            c.created_at,
            c.last_message_at,
            -- Informations de l'autre participant
            CASE WHEN c.user1_id = ? THEN c.user2_id ELSE c.user1_id END AS other_user_id,
            p.display_name  AS other_display_name,
            p.avatar_url    AS other_avatar_url,
            -- Dernier message via JOIN (remplace 3 DEPENDENT SUBQUERY corrélées)
            lm.content      AS last_message_content,
            lm.created_at   AS last_message_at_exact,
            lm.sender_id    AS last_message_sender_id,
            -- Nombre de messages non lus
            COALESCE(ur.unread_count, 0) AS unread_count
          FROM conversations c
          LEFT JOIN profiles p
            ON p.user_id = CASE WHEN c.user1_id = ? THEN c.user2_id ELSE c.user1_id END
          -- Dernier message : on jointure sur le max(id) par conversation
          LEFT JOIN messages lm
            ON lm.id = (
              SELECT id FROM messages
              WHERE conversation_id = c.id
              ORDER BY id DESC LIMIT 1
            )
          -- Comptage des non-lus en une seule sous-requête agrégée
          LEFT JOIN (
            SELECT conversation_id, COUNT(*) AS unread_count
            FROM messages
            WHERE sender_id != ? AND read_at IS NULL
            GROUP BY conversation_id
          ) ur ON ur.conversation_id = c.id
          WHERE c.user1_id = ? OR c.user2_id = ?
          ORDER BY c.last_message_at DESC
          LIMIT ${limit} OFFSET ${offset}`,
        [userId, userId, userId, userId, userId],
      );
 
      return sendSuccess(res, {
        conversations: rows.map((r) => ({
          id: r.id,
          createdAt: r.created_at,
          lastMessageAt: r.last_message_at,
          otherUser: {
            id: r.other_user_id,
            displayName: r.other_display_name || "Utilisateur",
            avatarUrl: r.other_avatar_url || null,
          },
          lastMessage: r.last_message_content
            ? {
                content: r.last_message_content,
                sentAt: r.last_message_at_exact,
                isOwn: r.last_message_sender_id === userId,
              }
            : null,
          unreadCount: Number(r.unread_count) || 0,
        })),
        pagination: { limit, offset },
      });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.getConversations error:",
        error: err,
        action: "messages_get_conversations",
        userId,
      });
    }
  }
 
  /**
   * POST /api/messages/conversations
   * Crée ou retrouve la conversation avec un autre utilisateur.
   * Body: { targetUserId: string }
   */
  static async startConversation(req, res) {
    const userId = req.user.id;
    const { targetUserId } = req.body;
 
    if (!targetUserId || typeof targetUserId !== "string") {
      return res
        .status(400)
        .json({ success: false, error: "targetUserId requis" });
    }
 
    if (targetUserId === userId) {
      return res
        .status(400)
        .json({ success: false, error: "Impossible de démarrer une conversation avec soi-même" });
    }
 
    try {
      // Vérifier que l'utilisateur cible existe et est actif
      const targetRows = await executeQuery(
        `SELECT id FROM users WHERE id = ? AND account_status = 'active' LIMIT 1`,
        [targetUserId],
      );
      if (!targetRows.length) {
        return res
          .status(404)
          .json({ success: false, error: "Utilisateur introuvable" });
      }
 
      // Vérifier que la cible autorise les messages privés
      const privacyRows = await executeQuery(
        `SELECT allow_private_messages FROM user_privacy_settings WHERE user_id = ? LIMIT 1`,
        [targetUserId],
      );
      // Par défaut : pas de ligne = messages non autorisés (DEFAULT 0)
      const allowsMessages = privacyRows.length > 0 ? !!privacyRows[0].allow_private_messages : false;
      if (!allowsMessages) {
        return res.status(403).json({
          success: false,
          error: "Cet utilisateur n'accepte pas les messages privés",
          code: "MESSAGES_DISABLED",
        });
      }
 
      // Vérifier qu'aucun blocage n'existe entre les deux utilisateurs
      const blocked = await isBlockedBetween(userId, targetUserId);
      if (blocked) {
        return res.status(403).json({
          success: false,
          error: "Impossible de démarrer une conversation avec cet utilisateur",
          code: "USER_BLOCKED",
        });
      }
 
      // Respecter la contrainte user1_id < user2_id
      const [u1, u2] = orderUsers(userId, targetUserId);
 
      // Upsert : retrouver ou créer
      await executeQuery(
        `INSERT IGNORE INTO conversations (user1_id, user2_id, created_at, last_message_at)
         VALUES (?, ?, NOW(), NOW())`,
        [u1, u2],
      );
 
      const conv = await executeQuery(
        `SELECT id, user1_id, user2_id, created_at, last_message_at
           FROM conversations
          WHERE user1_id = ? AND user2_id = ?
          LIMIT 1`,
        [u1, u2],
      );
 
      return sendSuccess(res, { conversation: conv[0] });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.startConversation error:",
        error: err,
        action: "messages_start_conversation",
        userId,
      });
    }
  }
 
  /**
   * GET /api/messages/conversations/:conversationId
   * Récupère les messages d'une conversation (pagination par curseur).
   * Query: before (id du dernier message connu), limit (max 50)
   */
  static async getMessages(req, res) {
    const userId = req.user.id;
    const convId = parseConvId(req.params.conversationId);
 
    if (!convId) {
      return sendInvalidId(res, "conversationId");
    }
 
    // Vérification d'appartenance
    const conv = await ensureConversationAccess({
      conversationId: convId,
      userId,
      res,
      warnAction: "messages_unauthorized_access",
      warnMessage: `Tentative d'accès à la conversation ${convId} par ${userId}`,
    });
    if (!conv) return;
 
    const limit = Math.min(Number.parseInt(req.query.limit, 10) || 30, 50);
    const before = Number.parseInt(req.query.before, 10) || null;
 
    try {
      let sql;
      let params;
 
      if (before && before > 0) {
        // Cursor-based : messages plus anciens que `before`
        sql = `SELECT m.id, m.sender_id, m.content, m.fail_ref_id, m.read_at, m.created_at,
                      m.deleted_at, m.reply_to_id,
                      p.display_name AS sender_display_name, p.avatar_url AS sender_avatar_url,
                      f.title AS fail_ref_title,
                      rm.content AS reply_content, rm.sender_id AS reply_sender_id,
                      rp.display_name AS reply_sender_name
                 FROM messages m
                 LEFT JOIN profiles p ON p.user_id = m.sender_id
                 LEFT JOIN fails f ON f.id = m.fail_ref_id
                 LEFT JOIN messages rm ON rm.id = m.reply_to_id
                 LEFT JOIN profiles rp ON rp.user_id = rm.sender_id
                WHERE m.conversation_id = ? AND m.id < ?
                ORDER BY m.id DESC
                LIMIT ${limit}`;
        params = [convId, before];
      } else {
        sql = `SELECT m.id, m.sender_id, m.content, m.fail_ref_id, m.read_at, m.created_at,
                      m.deleted_at, m.reply_to_id,
                      p.display_name AS sender_display_name, p.avatar_url AS sender_avatar_url,
                      f.title AS fail_ref_title,
                      rm.content AS reply_content, rm.sender_id AS reply_sender_id,
                      rp.display_name AS reply_sender_name
                 FROM messages m
                 LEFT JOIN profiles p ON p.user_id = m.sender_id
                 LEFT JOIN fails f ON f.id = m.fail_ref_id
                 LEFT JOIN messages rm ON rm.id = m.reply_to_id
                 LEFT JOIN profiles rp ON rp.user_id = rm.sender_id
                WHERE m.conversation_id = ?
                ORDER BY m.id DESC
                LIMIT ${limit}`;
        params = [convId];
      }
 
      const rows = await executeQuery(sql, params);
 
      // Charger les réactions pour les messages récupérés (batch)
      let reactionsMap = {};
      Eif (rows.length > 0) {
        const msgIds = rows.map((r) => r.id);
        const placeholders = msgIds.map(() => "?").join(",");
        const reactions = await executeQuery(
          `SELECT message_id, emoji, COUNT(*) AS count,
                  MAX(CASE WHEN user_id = ? THEN 1 ELSE 0 END) AS reacted_by_me
             FROM message_reactions
            WHERE message_id IN (${placeholders})
            GROUP BY message_id, emoji`,
          [userId, ...msgIds],
        );
        for (const r of reactions) {
          Eif (!reactionsMap[r.message_id]) reactionsMap[r.message_id] = [];
          reactionsMap[r.message_id].push({
            emoji: r.emoji,
            count: Number(r.count),
            reactedByMe: !!r.reacted_by_me,
          });
        }
      }
 
      // Retourner du plus ancien au plus récent (ordre chronologique)
      const messages = rows.toReversed().map((r) => ({
        id: r.id,
        senderId: r.sender_id,
        senderDisplayName: r.sender_display_name || "Utilisateur",
        senderAvatarUrl: r.sender_avatar_url || null,
        content: r.deleted_at ? null : r.content,
        isDeleted: !!r.deleted_at,
        failRef: r.fail_ref_id && !r.deleted_at
          ? { id: r.fail_ref_id, title: r.fail_ref_title || null }
          : null,
        replyTo: r.reply_to_id
          ? {
              id: r.reply_to_id,
              content: r.reply_content || null,
              senderId: r.reply_sender_id || null,
              senderDisplayName: r.reply_sender_name || "Utilisateur",
            }
          : null,
        reactions: reactionsMap[r.id] || [],
        readAt: r.read_at,
        createdAt: r.created_at,
        isOwn: r.sender_id === userId,
      }));
 
      return sendSuccess(res, {
        conversationId: convId,
        messages,
        hasMore: rows.length === limit,
      });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.getMessages error:",
        error: err,
        action: "messages_get_messages",
        userId,
      });
    }
  }
 
  /**
   * POST /api/messages/conversations/:conversationId
   * Envoie un message dans une conversation.
   * Body: { content: string, failRefId?: string, replyToId?: number }
   */
  static async sendMessage(req, res) {
    const userId = req.user.id;
    const convId = parseConvId(req.params.conversationId);
 
    if (!convId) {
      return sendInvalidId(res, "conversationId");
    }
 
    // Vérification d'appartenance
    const conv = await ensureConversationAccess({
      conversationId: convId,
      userId,
      res,
      warnAction: "messages_unauthorized_access",
      warnMessage: `Tentative d'envoi dans la conversation ${convId} par ${userId}`,
    });
    if (!conv) return;
 
    // Vérifier le blocage entre les participants
    const otherUser = conv.user1_id === userId ? conv.user2_id : conv.user1_id;
    const blocked = await isBlockedBetween(userId, otherUser);
    if (blocked) {
      return res.status(403).json({
        success: false,
        error: "Impossible d'envoyer un message à cet utilisateur",
        code: "USER_BLOCKED",
      });
    }
 
    const rawContent = req.body.content;
    if (typeof rawContent !== "string") {
      return res
        .status(400)
        .json({ success: false, error: "Le contenu du message est requis" });
    }
 
    // Sanity : strip null bytes + tronquer à 2000 caractères (double protection après validators)
    const content = rawContent.replaceAll('\x00', '').slice(0, 2000);
    if (!content) {
      return res
        .status(400)
        .json({ success: false, error: "Contenu du message vide après nettoyage" });
    }
 
    // Validation optionnelle du fail_ref_id
    const failRefId = req.body.failRefId ?? null;
    if (failRefId !== null && !await validateFailRef(failRefId, res)) return;
 
    // Validation optionnelle du reply_to_id
    const replyResult = await parseAndValidateReplyTo(req.body.replyToId, convId, res);
    Iif (!replyResult.valid) return;
    const replyToId = replyResult.replyToId;
 
    try {
      await executeQuery(
        `INSERT INTO messages (conversation_id, sender_id, content, fail_ref_id, reply_to_id, created_at)
         VALUES (?, ?, ?, ?, ?, NOW())`,
        [convId, userId, content, failRefId, replyToId],
      );
 
      // Mettre à jour last_message_at de la conversation
      await executeQuery(
        `UPDATE conversations SET last_message_at = NOW() WHERE id = ?`,
        [convId],
      );
 
      // Récupérer le message créé avec les infos utiles
      const msgRows = await executeQuery(
        `SELECT m.id, m.sender_id, m.content, m.fail_ref_id, m.reply_to_id, m.read_at, m.created_at,
                COALESCE(NULLIF(p.display_name,''), 'Utilisateur') AS sender_display_name, p.avatar_url AS sender_avatar_url,
                rm.content AS reply_content, rm.sender_id AS reply_sender_id,
                COALESCE(NULLIF(rp.display_name,''), 'Utilisateur') AS reply_sender_name
           FROM messages m
           LEFT JOIN profiles p ON p.user_id = m.sender_id
           LEFT JOIN messages rm ON rm.id = m.reply_to_id
           LEFT JOIN profiles rp ON rp.user_id = rm.sender_id
          WHERE m.conversation_id = ? AND m.sender_id = ?
          ORDER BY m.id DESC LIMIT 1`,
        [convId, userId],
      );
 
      const msg = msgRows[0];
      const payload = buildMsgPayload(msg, convId);
 
      // ⏰ Push temps réel via Socket.io
      const io = req.app.locals.io;
      io?.to(`conv:${convId}`).emit("new-message", { ...payload, isOwn: false });
      io?.to(`user:${otherUser}`).emit("new-message", { ...payload, isOwn: false });
      io?.to(`user:${otherUser}`).emit("unread-count-update");
 
      scheduleMsgPush(otherUser, convId, content, msg.sender_display_name || "Quelqu'un");
 
      return res.status(201).json({
        success: true,
        message: { ...payload, isOwn: true },
      });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.sendMessage error:",
        error: err,
        action: "messages_send_message",
        userId,
      });
    }
  }
 
  /**
   * POST /api/messages/conversations/:conversationId/read
   * Marque comme lus tous les messages non lus de l'autre utilisateur dans cette conversation.
   */
  static async markAsRead(req, res) {
    const userId = req.user.id;
    const convId = parseConvId(req.params.conversationId);
 
    if (!convId) {
      return sendInvalidId(res, "conversationId");
    }
 
    // Vérification d'appartenance
    const conv = await ensureConversationAccess({
      conversationId: convId,
      userId,
      res,
      warnAction: "messages_unauthorized_access",
      warnMessage: `Tentative de markAsRead sur conversation ${convId} par ${userId}`,
    });
    if (!conv) return;
 
    try {
      const result = await executeQuery(
        `UPDATE messages
            SET read_at = NOW()
          WHERE conversation_id = ?
            AND sender_id != ?
            AND read_at IS NULL`,
        [convId, userId],
      );
 
      const markedRead = result.affectedRows || 0;
 
      // Push temps réel si des messages ont réellement été marqués lus
      Eif (markedRead > 0) {
        const io = req.app.locals.io;
        Eif (io) {
          io.to(`conv:${convId}`).emit("messages-read", { conversationId: convId, readBy: userId });
          io.to(`user:${userId}`).emit("unread-count-update");
        }
      }
 
      return sendSuccess(res, { markedRead });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.markAsRead error:",
        error: err,
        action: "messages_mark_read",
        userId,
      });
    }
  }
 
  /**
   * GET /api/messages/unread-count
   * Retourne le nombre total de messages non lus pour l'utilisateur connecté.
   * Utilisé pour afficher le badge dans la tab bar.
   */
  static async getUnreadCount(req, res) {
    const userId = req.user.id;
 
    try {
      const rows = await executeQuery(
        `SELECT COUNT(*) AS total
           FROM messages m
           JOIN conversations c ON c.id = m.conversation_id
          WHERE (c.user1_id = ? OR c.user2_id = ?)
            AND m.sender_id != ?
            AND m.read_at IS NULL
            AND m.deleted_at IS NULL`,
        [userId, userId, userId],
      );
 
      return sendSuccess(res, { unreadCount: Number(rows[0]?.total) || 0 });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.getUnreadCount error:",
        error: err,
        action: "messages_get_unread_count",
        userId,
      });
    }
  }
 
  // ─── Point 2 : Soft-delete message ──────────────────────────────────────────
 
  /**
   * DELETE /api/messages/:messageId
   * Supprime (soft-delete) un message. Seul l'auteur peut supprimer.
   */
  static async deleteMessage(req, res) {
    const userId = req.user.id;
    const messageId = parseMessageId(req.params.messageId);
    if (!messageId) {
      return sendInvalidId(res, "messageId");
    }
 
    try {
      // Vérifier que le message appartient à l'utilisateur et est dans une de ses conversations
      const rows = await executeQuery(
        `SELECT m.id, m.sender_id, m.conversation_id, m.deleted_at
           FROM messages m
           JOIN conversations c ON c.id = m.conversation_id
          WHERE m.id = ?
            AND (c.user1_id = ? OR c.user2_id = ?)
          LIMIT 1`,
        [messageId, userId, userId],
      );
 
      if (!rows.length) {
        return sendMessageNotFound(res);
      }
 
      const msg = rows[0];
 
      // Seul l'auteur peut supprimer son propre message
      if (msg.sender_id !== userId) {
        return res.status(403).json({ success: false, error: "Vous ne pouvez supprimer que vos propres messages" });
      }
 
      if (msg.deleted_at) {
        return res.status(409).json({ success: false, error: "Message déjà supprimé" });
      }
 
      await executeQuery(
        `UPDATE messages SET deleted_at = NOW(), deleted_by = ? WHERE id = ?`,
        [userId, messageId],
      );
 
      // Notifier en temps réel
      const io = req.app.locals.io;
      Eif (io) {
        io.to(`conv:${msg.conversation_id}`).emit("message-deleted", {
          conversationId: msg.conversation_id,
          messageId,
        });
      }
 
      return sendSuccess(res);
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.deleteMessage error:",
        error: err,
      });
    }
  }
 
  // ─── Point 3 : Signalement de message ───────────────────────────────────────
 
  /**
   * POST /api/messages/:messageId/report
   * Signale un message. Body: { reason, details? }
   */
  static async reportMessage(req, res) {
    const userId = req.user.id;
    const messageId = parseMessageId(req.params.messageId);
    if (!messageId) {
      return sendInvalidId(res, "messageId");
    }
 
    const reason = req.body.reason;
    if (!reason || !VALID_REPORT_REASONS.has(reason)) {
      return res.status(400).json({
        success: false,
        error: "Raison de signalement invalide",
        allowed: [...VALID_REPORT_REASONS],
      });
    }
 
    // Tronquer details pour éviter injection de données volumineuses
    const rawDetails = req.body.details;
    const details = typeof rawDetails === "string"
      ? rawDetails.replaceAll('\x00', '').slice(0, 500)
      : null;
 
    try {
      // Vérifier que le message existe et que le rapporteur est dans la conversation
      const rows = await executeQuery(
        `SELECT m.id, m.sender_id FROM messages m
           JOIN conversations c ON c.id = m.conversation_id
          WHERE m.id = ?
            AND (c.user1_id = ? OR c.user2_id = ?)
            AND m.deleted_at IS NULL
          LIMIT 1`,
        [messageId, userId, userId],
      );
 
      if (!rows.length) {
        return sendMessageNotFound(res);
      }
 
      // Ne pas se signaler soi-même
      if (rows[0].sender_id === userId) {
        return res.status(400).json({ success: false, error: "Vous ne pouvez pas vous signaler vous-même" });
      }
 
      // UNIQUE KEY (message_id, reporter_id) — INSERT IGNORE pour éviter doublon
      const result = await executeQuery(
        `INSERT IGNORE INTO message_reports (message_id, reporter_id, reason, details)
         VALUES (?, ?, ?, ?)`,
        [messageId, userId, reason, details],
      );
 
      if (result.affectedRows === 0) {
        return res.status(409).json({ success: false, error: "Vous avez déjà signalé ce message" });
      }
 
      return res.status(201).json({ success: true });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.reportMessage error:",
        error: err,
      });
    }
  }
 
  // ─── Point 4 : Réactions sur messages ───────────────────────────────────────
 
  /**
   * POST /api/messages/:messageId/react
   * Ajoute ou retire une réaction. Body: { emoji }
   */
  static async reactToMessage(req, res) {
    const userId = req.user.id;
    const messageId = parseMessageId(req.params.messageId);
    if (!messageId) {
      return sendInvalidId(res, "messageId");
    }
 
    const emoji = req.body.emoji;
    if (!emoji || !ALLOWED_EMOJIS.has(emoji)) {
      return res.status(400).json({
        success: false,
        error: "Emoji non autorisé",
        allowed: [...ALLOWED_EMOJIS],
      });
    }
 
    try {
      // Vérifier que le message existe et que l'utilisateur est dans la conversation
      const rows = await executeQuery(
        `SELECT m.id, m.conversation_id FROM messages m
           JOIN conversations c ON c.id = m.conversation_id
          WHERE m.id = ?
            AND (c.user1_id = ? OR c.user2_id = ?)
            AND m.deleted_at IS NULL
          LIMIT 1`,
        [messageId, userId, userId],
      );
 
      if (!rows.length) {
        return sendMessageNotFound(res);
      }
 
      const convId = rows[0].conversation_id;
 
      // Toggle : si la réaction existe, la supprimer ; sinon l'ajouter
      const existing = await executeQuery(
        `SELECT id FROM message_reactions WHERE message_id = ? AND user_id = ? AND emoji = ? LIMIT 1`,
        [messageId, userId, emoji],
      );
 
      let action;
      if (existing.length) {
        await executeQuery(
          `DELETE FROM message_reactions WHERE message_id = ? AND user_id = ? AND emoji = ?`,
          [messageId, userId, emoji],
        );
        action = "removed";
      } else {
        await executeQuery(
          `INSERT INTO message_reactions (message_id, user_id, emoji) VALUES (?, ?, ?)`,
          [messageId, userId, emoji],
        );
        action = "added";
      }
 
      // Récupérer le comptage actualisé
      const counts = await executeQuery(
        `SELECT emoji, COUNT(*) AS count FROM message_reactions WHERE message_id = ? GROUP BY emoji`,
        [messageId],
      );
 
      const reactions = mapReactionCounts(counts);
      const io = req.app.locals.io;
      if (io) {
        io.to(`conv:${convId}`).emit("message-reaction", {
          conversationId: convId,
          messageId,
          emoji,
          action,
          userId,
          reactions,
        });
      }
 
      return sendSuccess(res, { action, reactions });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.reactToMessage error:",
        error: err,
      });
    }
  }
 
  // ─── Point 8 : Recherche dans une conversation ───────────────────────────────
 
  /**
   * GET /api/messages/conversations/:conversationId/search?q=
   * Recherche FULLTEXT dans les messages d'une conversation.
   */
  static async searchMessages(req, res) {
    const userId = req.user.id;
    const convId = parseConvId(req.params.conversationId);
    if (!convId) {
      return sendInvalidId(res, "conversationId");
    }
 
    const conv = await getConversationIfMember(convId, userId);
    if (!conv) return res.status(403).json({ success: false, error: "Accès refusé" });
 
    const q = typeof req.query.q === "string" ? req.query.q.trim().replaceAll('\x00', '').slice(0, 100) : "";
    if (q.length < 2) {
      return res.status(400).json({ success: false, error: "La recherche doit contenir au moins 2 caractères" });
    }
 
    const limit = Math.min(Number.parseInt(req.query.limit, 10) || 20, 50);
 
    try {
      // FULLTEXT search en mode booléen pour performances
      const rows = await executeQuery(
        `SELECT m.id, m.sender_id, m.content, m.created_at,
                p.display_name AS sender_display_name,
                MATCH(m.content) AGAINST (? IN BOOLEAN MODE) AS relevance
           FROM messages m
           LEFT JOIN profiles p ON p.user_id = m.sender_id
          WHERE m.conversation_id = ?
            AND m.deleted_at IS NULL
            AND MATCH(m.content) AGAINST (? IN BOOLEAN MODE)
          ORDER BY relevance DESC, m.id DESC
          LIMIT ${limit}`,
        [q, convId, q],
      );
 
      return sendSuccess(res, {
        results: rows.map((r) => ({
          id: r.id,
          senderId: r.sender_id,
          senderDisplayName: r.sender_display_name || "Utilisateur",
          content: r.content,
          createdAt: r.created_at,
          isOwn: r.sender_id === userId,
        })),
        query: q,
      });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.searchMessages error:",
        error: err,
      });
    }
  }
 
  // ─── Points 6 + 10 : Paramètres de conversation (mute + archive) ─────────────
 
  /**
   * PUT /api/messages/conversations/:conversationId/settings
   * Met à jour les paramètres personnels : mute et/ou archive.
   * Body: { isMuted?: boolean, archived?: boolean }
   */
  static async updateConversationSettings(req, res) {
    const userId = req.user.id;
    const convId = parseConvId(req.params.conversationId);
    if (!convId) {
      return sendInvalidId(res, "conversationId");
    }
 
    const conv = await getConversationIfMember(convId, userId);
    if (!conv) {
      return res.status(403).json({ success: false, error: "Accès refusé" });
    }
 
    const { isMuted, archived } = req.body;
    if (isMuted === undefined && archived === undefined) {
      return res.status(400).json({ success: false, error: "Aucun paramètre fourni (isMuted, archived)" });
    }
 
    try {
      // Lire les settings existants
      const existing = await executeQuery(
        `SELECT is_muted, archived_at FROM conversation_settings WHERE user_id = ? AND conversation_id = ? LIMIT 1`,
        [userId, convId],
      );
 
      const currentMuted = existing.length ? !!existing[0].is_muted : false;
      const currentArchived = existing.length ? !!existing[0].archived_at : false;
 
      const newMuted = isMuted === undefined ? currentMuted : !!isMuted;
      const newArchived = archived === undefined ? currentArchived : !!archived;
 
      await executeQuery(
        `INSERT INTO conversation_settings (user_id, conversation_id, is_muted, archived_at)
         VALUES (?, ?, ?, ?)
         ON DUPLICATE KEY UPDATE
           is_muted = VALUES(is_muted),
           archived_at = VALUES(archived_at),
           updated_at = NOW()`,
        [userId, convId, newMuted ? 1 : 0, newArchived ? new Date() : null],
      );
 
      return sendSuccess(res, { isMuted: newMuted, archived: newArchived });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.updateConversationSettings error:",
        error: err,
      });
    }
  }
 
  // ─── Point 9 : Blocage utilisateur ciblé ─────────────────────────────────────
 
  /**
   * POST /api/messages/block/:targetUserId
   * Bloque un utilisateur ciblé.
   */
  static async blockUser(req, res) {
    const userId = req.user.id;
    const targetUserId = req.params.targetUserId;
 
    if (!targetUserId || typeof targetUserId !== "string" || targetUserId === userId) {
      return res.status(400).json({ success: false, error: "targetUserId invalide" });
    }
 
    try {
      // Vérifier que la cible existe
      const targetUser = await findUserById(targetUserId);
      if (!targetUser) {
        return res.status(404).json({ success: false, error: "Utilisateur introuvable" });
      }
 
      // INSERT IGNORE : silencieux si déjà bloqué
      await executeQuery(
        `INSERT IGNORE INTO user_blocks (blocker_id, blocked_id) VALUES (?, ?)`,
        [userId, targetUserId],
      );
 
      return res.status(201).json({ success: true });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.blockUser error:",
        error: err,
      });
    }
  }
 
  /**
   * DELETE /api/messages/block/:targetUserId
   * Débloque un utilisateur ciblé.
   */
  static async unblockUser(req, res) {
    const userId = req.user.id;
    const targetUserId = req.params.targetUserId;
 
    if (!targetUserId || typeof targetUserId !== "string") {
      return sendInvalidId(res, "targetUserId");
    }
 
    try {
      await executeQuery(
        `DELETE FROM user_blocks WHERE blocker_id = ? AND blocked_id = ?`,
        [userId, targetUserId],
      );
      return sendSuccess(res);
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.unblockUser error:",
        error: err,
      });
    }
  }
 
  /**
   * GET /api/messages/blocks
   * Liste les utilisateurs bloqués par l'utilisateur connecté.
   */
  static async getBlockedUsers(req, res) {
    const userId = req.user.id;
    try {
      const rows = await executeQuery(
        `SELECT ub.blocked_id, p.display_name, p.avatar_url, ub.created_at
           FROM user_blocks ub
           LEFT JOIN profiles p ON p.user_id = ub.blocked_id
          WHERE ub.blocker_id = ?
          ORDER BY ub.created_at DESC`,
        [userId],
      );
      return sendSuccess(res, {
        blocks: rows.map(mapBlockedUserRow),
      });
    } catch (err) {
      return logAndSendServerError(res, {
        label: "MessagesController.getBlockedUsers error:",
        error: err,
      });
    }
  }
}
 
MessagesController.__testables = {
  ALLOWED_EMOJIS,
  VALID_REPORT_REASONS,
  parseConvId,
  getConversationIfMember,
  orderUsers,
  parseMessageId,
  isBlockedBetween,
  validateFailRef,
  parseAndValidateReplyTo,
  buildMsgPayload,
  scheduleMsgPush,
};
 
module.exports = MessagesController;